Yes, I know that in "our" case the patch is purely cosmetic but IMO it is good practice to write code which conforms to standard(s). Especially when it doesn't cost much. Consolidated patch is attached.
Regards, /J.D. ** Patch added: "Wreorder.patch" https://bugs.launchpad.net/hugin/+bug/1538247/+attachment/4557810/+files/Wreorder.patch -- You received this bug notification because you are a member of Hugin Developers, which is subscribed to Hugin. https://bugs.launchpad.net/bugs/1538247 Title: Wrong order of member initializers Status in Hugin: Fix Committed Bug description: While compiling with "g++ -Wall" a lot of warnings of this type are reported: In file included from d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:57:0: d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h: In constructor 'MyExecPanel::MyExecPanel(wxWindow*)': d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:110:10: warning: 'MyExecPanel::m_checkReturnCode' will be initialized after [-Wreorder] bool m_checkReturnCode; ^ d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:108:12: warning: 'size_t MyExecPanel::m_queueLength' [-Wreorder] size_t m_queueLength; ^ d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:77:1: warning: when initialized here [-Wreorder] MyExecPanel::MyExecPanel(wxWindow * parent) ^ More info is here: http://stackoverflow.com/questions/1828037/whats- the-point-of-g-wreorder The patch is attached. Regards, /J.D. To manage notifications about this bug go to: https://bugs.launchpad.net/hugin/+bug/1538247/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~hugin-devs Post to : [email protected] Unsubscribe : https://launchpad.net/~hugin-devs More help : https://help.launchpad.net/ListHelp
