2009/6/3 Gerry Patterson <[email protected]>: > Hi All, > > I have checked in a fix for this as of Rev 3908. I was able to trigger the > error by: > > loading project (this project only had 2 images) > opening gl preview > removing image > dragging image > > Once I let go of the left mouse button, it would crash every time. > > Best Regards, > > - Gerry > > > 2009/6/2 Lukáš Jirkovský <[email protected]> >> >> 2009/6/2 Gerry Patterson <[email protected]>: >> > >> > Hello, >> > >> > Crash? My memory is fuzzy, I don't remember a crash. Is there a bug >> > report >> > in the tracker on this I can check? >> > >> > - Gerry >> > >> > 2009/6/2 Lukáš Jirkovský <[email protected]> >> >> >> >> 2009/6/2 Gerry Patterson <[email protected]>: >> >> > >> >> > Hi All, >> >> > >> >> > I believe I have found the problem. I have commit-ed a fix as of rev >> >> > 3904. >> >> > The fast preview would realize it needed to regenerate textures, but >> >> > wouldn't store their metadata properly. So it kept regenerating >> >> > again, >> >> > and >> >> > again.... >> >> > >> >> > Best Regards, >> >> > >> >> > - Gerry >> >> > >> >> > >> >> > On Mon, Jun 1, 2009 at 9:13 PM, Gerry Patterson >> >> > <[email protected]> >> >> > wrote: >> >> >> >> >> >> Hello, >> >> >> >> >> >> Just posting my findings... >> >> >> >> >> >> I believe I am seeing this problem under linux. If I load a pano >> >> >> project >> >> >> and open the fast preview window. There is a slight delay and then >> >> >> I >> >> >> can >> >> >> smoothly move the pano around as excepted. If I then re-optimize >> >> >> the >> >> >> pano >> >> >> and try to drag around, the performace has dropped considerably. I >> >> >> profiled and found that vigra::resizeImageNoInterpolation() from >> >> >> resizeimage.hxx line 279 is using 88% of cpu time when this is >> >> >> happening. >> >> >> Profiling the good case shows the same function using 11%. I am >> >> >> sure >> >> >> this >> >> >> would drop if I ran the program longer. >> >> >> >> >> >> >> >> >> So...why is vigra::resizeImageNoInterpolation() getting called so >> >> >> often >> >> >> when dragging the pano around after re-optimizing? This is >> >> >> something >> >> >> to >> >> >> look into. My free time has dropped to zero lately, so it may be a >> >> >> while >> >> >> before I can look at this futher. But it may point someone in the >> >> >> right >> >> >> direction. >> >> >> >> >> >> Best Regards, >> >> >> >> >> >> - Gerry >> >> >> >> >> >> >> >> >> >> >> >> On Mon, Jun 1, 2009 at 6:02 PM, Benjamin Schnieders >> >> >> <[email protected]> wrote: >> >> >>> >> >> >>> I first couldn't decide here, but after an evening of >> >> >>> waiting-for-preview-to-close, saving panorama and reloading it, >> >> >>> just >> >> >>> to >> >> >>> be able to quickly identify some freak images in between the others >> >> >>> and >> >> >>> deleting them I vote for fixing this bug as soon as possible, and >> >> >>> if >> >> >>> needed waiting with the 0.8 release until it is fixed, as it is - >> >> >>> in >> >> >>> my >> >> >>> opinion - pretty simple to reproduce this bug (I can't imagine this >> >> >>> won't happen to anyone) by just removing an image while using the >> >> >>> preview or re-optimizing while the preview is closed. >> >> >>> >> >> >>> If there might be a fix for this I'll try a recent trunk version by >> >> >>> tomorrow... :) >> >> >>> >> >> >>> Benjamin >> >> >>> >> >> >>> >> >> >> >> >> > >> >> > >> >> > > >> >> > >> >> >> >> I can't see any slowdown now. Only the crash (but It crashed also with >> >> the svn 3888). I don't know if this crash is there for a long time or >> >> not, because in fact today was the first day I've tried to reproduce >> >> the slowdown which after a while causes crash. >> >> >> >> >> > >> > >> > > >> > >> >> I'm not sure, I'll take a look into bugtracker. Anyway, debugger gave >> me this info: >> >> hugin: >> /home/lukas/DEBUG/test-build/src/hugin-build/src/hugin_base/panodata/Panorama.cpp:1489: >> virtual void HuginBase::Panorama::setSrcImage(unsigned int, const >> HuginBase::SrcPanoImage&): Assertion `imgNr < state.images.size()' >> failed. >> >> So it may not be a crash but an assertion error. >> >> I don't know what exactly triggers it, but it seems that when I open >> the GL preview then remove some image, re-optimize it (It's exactly >> the same process as what I needed for reproduce slowdown in GL >> preview) then open the preview, select drag and play a bit it aborts. >> >> > > > > >
Wow, that was fast. Thanks a lot, it would take me much more time to find where the problem is, because I'm unfamiliar with the preview code. Lukáš --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx -~----------~----~----~----~------~----~------~--~---
