I just read your patch, to see if I could spot a bug (without
compiling, as an exercise), and I think I've found one. Can't compile
it myself now because I haven't currently set up a building
environment, but here goes:
Line 175 currently reads:
+ while ( (commands[nextCmd]->getName()=="change active
images") && (nextCmd < commands.size()) ) {
This should be:
+ while ( (nextCmd < commands.size() && (commands[nextCmd]-
>getName()=="change active images")) ) {
You were reading the name of a command which may not exist when at the
very end of the queue,
--
Bart
On 21 sep, 23:38, Yuval Levy <[email protected]> wrote:
> Hi all
>
> Hugin keeps track of all operations done on the panorama. Great for undo.
>
> It also stores the toggling of an image visibility status. Personally I find
> this unnecessary: when I move forth and back over the history of the project
> I am interested in "before and after", not "visible and invisible". I end up
> clicking multiple times to get through an undo/redo cycle if in between I
> toggled visibility (e.g. to influence the set of CPs used by the optimizer).
>
> In an attempt to work around the issue by simulating the multiple clicks, I
> produced the attached patch. It's not perfect yet, and has segfaulted on me
> on "redo". It's fairly simple. I look forward for critique and feedback of
> the patch and I hope to fix the segfault soon.
>
> Yuv
>
> selective.undo.patch
> 7KWeergevenDownloaden
>
> signature.asc
> < 1 KWeergevenDownloaden
--
You received this message because you are subscribed to the Google Groups
"Hugin and other free panoramic software" group.
A list of frequently asked questions is available at:
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at http://groups.google.com/group/hugin-ptx
