Thomas. Apologies for the re-posting.. I did not see the orignal appear in the group? Since I'd used another emailer to send it I assumed it had been block.
Yes I'd completely over-looked the fact that non-adjacent images could be selected.. The 'shuffling' of image does generate alot of 'history'. I'd been thinking about Yuv's recent post on undo history. For some reason I never use undo, not that I don't make mistakes, just Hugin provides other ways to get around mistakes... So again I never thought to test this patch for it's undo behavoiur. Looks like I do want to write methods to delete and insert images into the list. Thank-you for taking the time to review the patch.. Regards Stephen On Sep 10, 12:01 pm, "T. Modes" <[email protected]> wrote: > Hi Steeve, > > > Seems too easy, can anybody see anything I've missed? > > The patch needs more work: > 1.) First, it creates for every image an own command in the command > history, what makes is complicated to use the undo function. > 2.) Your patch goes mad, if you select several non-adjacent images. In > this case it moves n images following the first selected image (with n > the number of selected images), but not the selected images. This is > the main reason why moving several images is not so easy. You can not > assume that all selected images are adjacent. If you force this, you > break exisiting functionality. > > Thomas -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx
