I agree that more sophisticated behavior would be helpful. Sometimes, the view in the magnifier is so "enhanced" that it no longer looks much like the area the cursor is over. This makes it difficult to determine which feature you might *actually* be selecting.

Sometimes, "more contrast" isn't really the best choice. Often, simply "lighter" would do nicely. And for very light areas "more contrast" often results in a hard to read "blown out" look.

eo


On Dec 18, 2010, at 2:29 PM, davidefa wrote:

I have already noticed a 'strange' behaviour of the magnifier in the
control point editor panel ( but never understood it ).
Today I loaded in hugin a few astronomical images ( see thread [1] ),
and while adding a few cp I noticed that when the magnifier was
positioned on the dark background ( no bright stars in the fov of the
magnifier ) it showed a 'bright and dark texture', I couldn't
understand where it came from.
Searching in the code found that before being displayed the magnifier
is 'contrast enhanced' ( the darkest part of the image is converted to
back, the brightest part is converted to 255, max brightness ).
This is to help identifying 'features' in the images.
But when the magnifier is placed on a low contrast part of the image
( a generic image, not the astronomical image I refered above ) this
amplification ( contrast enhancement ) could be very high and this
seems a little bit confusing to me ( I mean the magnifier show a very
high contrast on a part of the image which has very low contrast ).
I think we could/should limit the maximum contrast enhancement.


in file CPImageCtrl.cpp line 601
  // transform to range 0...255
vigra::transformImage(vigra::srcImageRange(magImg), vigra::destImage(magImg),
                        vigra::linearRangeMapping(
VT(minmax.min), VT(minmax.max), // src range
                          VT(0), VT(255)) // dest range
                        );



[1] 
http://groups.google.com/group/hugin-ptx/browse_thread/thread/06c616c5f57c6787#
[2] http://www.davidefabbri.net/files/panorama/magnifier.zip


--
You received this message because you are subscribed to the Google Groups "Hugin and 
other free panoramic software" group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at http://groups.google.com/group/hugin-ptx

Reply via email to