Hi developers I would like to get rid of autopano-noop.sh and related cruft in the codebase.
As Bruno mentioned previously, silently removing it will affect negatively
users that have it set in their preferences. So I am trying to make sense of
how to detect such outdated preferences and how to deal with them.
The code for the settings has changed a lot. The body of preferences/setting
is still stored in the same place and read with
wxConfigBase * cfg = wxConfigBase::Get();
but what is in there has changed considerably. Back in the old days:
cfg->Read(wxT("/AutoPano/Type"),HUGIN_AP_TYPE);
was a binary specifying one of two available CP generators.
Today
cfg->Read(wxT("/AutoPano/AutoPanoCount"),0l);
gives the count of available CP generators.
Question: has something been done to get rid of the old /AutoPano/Type on
upgrade, or can I expect to find this cruft in the preferences settings of
users who have gone through continuous upgrades?
Does it make sense, if I find an old /AutoPano/Type entry, to warn the user?
or silently delete it? and reset to the new default? or is it possible that
the user has already configured other defaults and the old entry is just dead
weight?
Furthermore, in the old days the possible settings were stored in:
/AutoPanoSift/AutopanoExe
/AutoPanoSift/AutopanoExeCustom
/AutoPanoSift/Args
/AutoPanoKolor/AutopanoExe
/AutoPanoKolor/Args
IIRC, autopano-noop could be entered only into /AutoPanoSift/AutopanoExe? Or
should also /AutoPanoKolor/AutopanoExe be checked? Does Hugin currently use
these settings, or are they just ignored cruft? And if they are ignored
cruft, how does Hugin behave on upgrade? simply use/install the new default
settings because it did not find any valid settings?
In the current preferences it's /AutoPano/Autopano_<N> with <N> being an
incremental number. Is it possible that somebody has autopano-noop.sh
specified in the current settings? If yes, do I only have to look for
/AutoPano/Autopano_<N>/Program, or are there other places to look?
If there is an entry /AutoPano/Autopano_<N>/Program pointing to autopano-noop,
is it safe to just replace it with a default cpfind entry?
Yuv
signature.asc
Description: This is a digitally signed message part.
