Hi Kay, On December 28, 2010 05:50:24 am kfj wrote: > I'd like to hear some feedback. The latest revision is in my bazaar main > branch at the above-mentioned locations.
sorry for not reacting on this as quickly as I wished. One feedback for you: if you want developers to give you feedback, you need to make their life easy. the most effective way to publish such changes for review is a diff file. inside your modified source tree, do: hg pull && hg up hg diff tools/pano_trafo.cpp > mods.diff attach mods.diff to a tracker ticket (or post it to the ML). > I could also make a version that optionally takes an image number on > the command line and then behaves like the original version - and if > the image number isn't passed, it behaves like my new version. This > would preserve the original interface and add the new functionality. > What do you think? > > Kay
signature.asc
Description: This is a digitally signed message part.
