Hi all! While going through various hugin header files in the process of sucking a good selection into the scripting interface, I have looked at SrcPanoImage.h; on my system it lives in hugin.hg/src/hugin_base/ panodata.
This header includes diff2D.hxx in hugin.hg/src/foreign/vigra/vigra. The only bit that is used from this header are the definition of Size2D and Point2D, and as far as I can tell they are used simply to input a pair of integral coordinates as parameters to methods declared in the header. I feel this unnecessarily bloats the interface: in order simply to be able to pass the coordinate pairs in as vigra types, diff2D.hxx is included, which includes further vigra headers. SrcPanoImage.cpp makes some use of vigra functionality, and including the appropriate vigra headers into the cpp file poses no problem, but why do they have to be in the header? I feel it would be equivalent to let the affected routines be called with two ints instead, like: void SrcPanoImage::resize(const int& x, const int& y) instead of void SrcPanoImage::resize(const vigra::Size2D & sz) Kay -- You received this message because you are subscribed to the Google Groups "Hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hugin-ptx
