Am Samstag, 31. Oktober 2015 06:05:58 UTC+1 schrieb Groogle: > > > I still don't understand what is going on here. I've read the name > lookup rules at > http://en.cppreference.com/w/cpp/language/unqualified_lookup , and I'm > still not 100% convinced I understand them. In any case, it seems > that the templates in v1/mutex get looked at before the locally > defined lock. Maybe there's some cast that can be used to force it to > look at the definition, but changing the name works as well. I'm > attaching patches. >
The cluprit is probably "using namespace std;" so that all functions in std namespace can be used without adding "std::" This is already fixed in default branch. > > Another issue I had was in > src/hugin1/icpfind/AutoCtrlPointCreator.cpp. It has conditional code > for GCC, but it seems that clang defines __GNUC__ anyway. I've made > this conditional on __FreeBSD__, though this is probably not the right > way to go. > Thanks for patch. It is now fixed in default branch. > > clang finds many causes for warnings while building Hugin. I'd like > to remove the more obvious ones (like using the obsolete 'register' > keyword), but I don't want to do it every time. If I submit patches, > will they be incorporated into the tree? > Yes. But please submit patches against default branch and not against 2015.0. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/2ba80c7b-d11f-4b40-aa0a-7f12051ab6ff%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
