Hi Thomas, Thanks for your patience with me. And thanks for catching those final uints. New skyfill_tif.c is back on github now.
I am not familiar with CMake other than as a user of it. I had commented out those couple of lines to see if I could get it to run at all. Then I discovered it needed the math library. The CMakelists.txt you have provided won't work on my system (Linux Mint 19.3, CMake version 3.10.2) As it is a stable version of Mint, it can be pretty out of date on some packages. Here is the output when I run cmake: --- *CMake Error at CMakeLists.txt:5 (cmake_policy): Policy "CMP0074" is not known to this version of CMake.-- Looking for exp in m-- Looking for exp in m - foundCMake Error at CMakeLists.txt:46 (install): install TARGETS given no RUNTIME DESTINATION for executable target "skyfill".-- Configuring incomplete, errors occurred!See also "/home/welty/images/src/skyfill/build/CMakeFiles/CMakeOutput.log".* --- No rush to fix this. I'm using the original Makefile I had which is lets me keep working with the code and trying it out. Jeff On Thursday, December 23, 2021 at 1:48:23 AM UTC-8 T. Modes wrote: > Hi Jeff, > > you missed some necessary changes in skyfill_tiff.c - see attached patch. > > Also your changes to the CMake system breaks building on Windows: > * The cmake policy was explicitly set to silence warning in underlying > FindPackage(TIFF). > * You commented out the install target. It does not install the files > automatically. Instead it adds only an install target. So by default it > does nothing. But it's nice to have it available to easier get access to > the generated executables. > * Never hardcode library names as with libm. You need to check it before > usage. > > See attached second patch. > > Thomas > -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/3e9b92e1-6ec6-4c2b-ba79-327d85424590n%40googlegroups.com.
