jak schrieb am Mittwoch, 15. Mai 2024 um 19:49:57 UTC+2: my experience has been that cpfind creates a fair number of outright bad points and a few that are just a bit off and fine-tune tends to fix all of that fairly cleanly (where cpclean tends to miss many of these)
then this should be fixed in cpfind, don't it? This should be tried first before introducing a new tool. Maybe you could try this first? So only if this does not help, the patch could be taken into consideration. But then the patch needs a lot of reworking: * Don't duplicate code of base algorithms. That makes the maintenance more difficult than necessary. So both places should use the same code. * When using wx functions in a program you need to initialize the wx library before. Command line tools should use wxWidgets only if absolute necessary (some single program need it, but most cli are not depended on wxWidgets). * Also the image cache needs some more initialization before using it. * You are using nearly the whole alphabet for switches. Not all switches are really necessary to tweak by the user (e.g. reproject, alternate, maybe other also). Some are totally unnecessary: the correlation is always between 0 and 1. No need to clean cp with correlation >1.0 - this does not happen. Also is really the tweaking of the curvature necessary? This adds a lot of complexity to the command line, documentation but also to the code, which is not necessary. There are many options technical possible, but it makes no sense to expose all finer details to the user. For some it is better to use sensible fixed default values. * There may be other issues I have miss at a first scan of the code. And then there are more formal issues * Please provide an unified diff file with all changes in a single file. And not several files with the comment "feel free to put it wherever" (your words) * Unnecessary code should be removed and not commented out only with the comment "not sure what these do but everything seems to work fine without it?". This helps nobody and adds only garbage. * Please use our indentation/brace style (most new code is Allman style based) and don't mix in the same file. -- A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ --- You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/240af542-57fd-454e-9e17-2591257dbd03n%40googlegroups.com.
