Now that I try to implement it, I remember why an inline is convenient: it doesn't require any build-time/run-time dependency unless you really use it. If we make this code non-inline, we actually need libibverbs at build time and runtime. Distro packages will have to depend on libibverbs, and we'll get lots of complaints. Same for linux-libnuma.h and maybe nvidia cuda one day :) So we'll probably end up splitting this code out of libhwloc.so and make a libhwloc-openfabrics-verbs.so.
Brice Jeff Squyres wrote: > My vote: +1 for before v0.9.1 release. > > > On Oct 21, 2009, at 3:20 PM, Brice Goglin wrote: > >> Jeff Squyres wrote: >> > On Oct 20, 2009, at 8:33 PM, Jeff Squyres wrote: >> > >> >> Brice -- do you need to move r1195 and r1196 to the v0.9 branch? >> > >> > I effectively just brought these over to the v0.9 branch. >> > >> > With all these changes, I'll cut an rc2 and post it shortly. >> >> >> Am I still supposed to make the verbs helper not inline anymore ? >> >> Brice >> >> _______________________________________________ >> hwloc-devel mailing list >> hwloc-de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel >> > >
