On Fri, Mar 12, 2010 at 00:03, Brice Goglin <brice.gog...@inria.fr> wrote: > > Did you actually test this ? The way I am reading the manpage is that > you need to open with setmntent and close with endmntent.
I have read the man page, but only about getmntent, and than read the source code for getmntent from glibc. So yes, it is better to use setmntent/endmntent to be conform. > Also, isn't getmntent (without _r) enough here? I do not know the policy from this library regarding thread safety, so I decided to be on the safe side here. > > And finally, it seems to me that hasmntopt is probably the best way to > look for the 'cpuset' option. Yes, thats perfect. Didn't read this neither. > > Thanks a lot for the patch anyway, we should probably use something like > this instead of my manual parsing code. I see some potential configure > problems on HP-UX in Google, I might put the configure checks inside "if > Linux". We might even not need any configure checks since only Linux > uses all this so far. I'll play with all this tomorrow and probably > commit something. Thanks. I can post an updated patch which uses the input from this thread. Bert > > Brice
