It also seems to me that XML checks should move from HWLOC_SETUP_UTILS to HWLOC_SETUP_CORE. XML is used inside the core library and some people might use it even when embedded. For instance the MPI launcher could discover node topologies, do stuff with them, store them inside XML files, and let the MPI processes read them later when needed.
Jeff, do you get XML support when building hwloc inside OMPI? Brice Le 17/07/2010 10:26, bgog...@osl.iu.edu a écrit : > Author: bgoglin > Date: 2010-07-17 04:26:47 EDT (Sat, 17 Jul 2010) > New Revision: 2336 > URL: https://svn.open-mpi.org/trac/hwloc/changeset/2336 > > Log: > numa_bitmask_alloc is only needed in tests, move the relevant configure stuff > in HWLOC_SETUP_TESTS > Text files modified: > trunk/config/hwloc.m4 | 3 --- > > trunk/config/hwloc_internal.m4 | 4 ++++ > > 2 files changed, 4 insertions(+), 3 deletions(-) > > Modified: trunk/config/hwloc.m4 > ============================================================================== > --- trunk/config/hwloc.m4 (original) > +++ trunk/config/hwloc.m4 2010-07-17 04:26:47 EDT (Sat, 17 Jul 2010) > @@ -523,9 +523,6 @@ > > AC_CHECK_FUNCS([openat], [hwloc_have_openat=yes]) > > - AC_CHECK_DECL([numa_bitmask_alloc], [hwloc_have_linux_libnuma=yes], [], > - [#include <numa.h>]) > - > AC_CHECK_HEADERS([pthread_np.h]) > AC_CHECK_DECLS([pthread_setaffinity_np],,[:],[[ > #include <pthread.h> > > Modified: trunk/config/hwloc_internal.m4 > ============================================================================== > --- trunk/config/hwloc_internal.m4 (original) > +++ trunk/config/hwloc_internal.m4 2010-07-17 04:26:47 EDT (Sat, 17 Jul > 2010) > @@ -253,6 +253,10 @@ > > hwloc_build_tests=yes > > + # linux-libnuma.h testing requires libnuma with numa_bitmask_alloc() > + AC_CHECK_DECL([numa_bitmask_alloc], [hwloc_have_linux_libnuma=yes], [], > + [#include <numa.h>]) > + > # Only generate these files if we're making the tests > AC_CONFIG_FILES( > hwloc_config_prefix[tests/Makefile ] > _______________________________________________ > hwloc-svn mailing list > hwloc-...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-svn >
