Trunk still looks good, and backporting to v1.4 makes the warning go away, so I am backporting.
Brice Le 06/07/2012 23:58, Jeff Squyres a écrit : > Can you try trunk r4574? > > ifdef vs m4_ifdef -- I'm not actually sure, so I went with m4_ifdef. > > > On Jul 6, 2012, at 4:39 PM, Brice Goglin wrote: > >> This causes this warning during autogen (only in the v1.4 branch, but I >> don't see why): >> >> configure.ac:141: warning: AC_COMPILE_IFELSE was called before >> AC_USE_SYSTEM_EXTENSIONS >> config/hwloc.m4:24: HWLOC_SETUP_CORE is expanded from... >> configure.ac:141: the top level >> >> Moving the line after SETUP_CORE removes the warning. >> >> By the way, are ifdef and m4_ifdef identical? We used m4_ifdef in other >> similar cases. >> >> Brice >> >> >> >> >> Le 06/07/2012 21:56, svn-commit-mai...@open-mpi.org a écrit : >>> Author: jsquyres (Jeff Squyres) >>> Date: 2012-07-06 15:56:37 EDT (Fri, 06 Jul 2012) >>> New Revision: 4569 >>> URL: https://svn.open-mpi.org/trac/hwloc/changeset/4569 >>> >>> Log: >>> Merge r4568 from trunk: accomodate Automake 1.12.x >>> >>> Properties modified: >>> branches/v1.4/ (props changed) >>> Text files modified: >>> branches/v1.4/configure.ac | 3 +++ >>> >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> >>> Modified: branches/v1.4/configure.ac >>> ============================================================================== >>> --- branches/v1.4/configure.ac Fri Jul 6 15:55:31 2012 (r4568) >>> +++ branches/v1.4/configure.ac 2012-07-06 15:56:37 EDT (Fri, 06 Jul >>> 2012) (r4569) >>> @@ -110,6 +110,9 @@ >>> AC_PROG_CC >>> AM_PROG_CC_C_O >>> CFLAGS="$CFLAGS_save" >>> +# This did not exist pre AM 1.11.x (where x is somewhere >0 and <3), >>> +# but it is necessary in AM 1.12.x. >>> +ifdef([AM_PROG_AR], [AM_PROG_AR]) >>> >>> # Define hwloc's configure arguments >>> HWLOC_DEFINE_ARGS >>> _______________________________________________ >>> hwloc-svn mailing list >>> hwloc-...@open-mpi.org >>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-svn >> _______________________________________________ >> hwloc-devel mailing list >> hwloc-de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel >
