On 05/05/2013 12:05 PM US Central Time, Brice Goglin wrote: > Le 05/05/2013 18:18, Pavan Balaji a écrit : >> - hwloc's check for whether an explicitly function declaration is >> needed (using _HWLOC_CHECK_DECL) was relying on whether a dummy call to >> the function throws an error. This only works if the function >> declaration is already present in one of the headers. If such a >> declaration is not present, the test might fail with "implicit function >> declaration" with the right CFLAGS. This leads the m4 macro to think >> that the declaration is already there in one of the headers and an >> additional declaration is not needed. > > I'll look at this, when/where did you need this? (for documentation and > maybe testing one day)
Sorry, forgot to mention. The fls and flsl function checks fail without this in our strict builds. >> 2. I had reported an issue with libltdl in embedded mode (also in the >> above thread). I believe Brice is looking into this, so I didn't >> investigate it further. >> [...] >> I'd appreciate a cleaner fix to this issue. > > I am waiting for Jeff's feedback in thread "hwloc embedding vs libltdl". > > Not sure yet I will backport this into v1.7.1 since it is somehow > intrusive. To be discussed Ok, I'll carry our workaround forward in the mpich-3.1.x series. > To summarize: > * 1 partially applied, and the rest will likely be taken care of > * 2 needs review by Jeff > * 3-4 are fixed Great. Thanks. -- Pavan -- Pavan Balaji http://www.mcs.anl.gov/~balaji
