On 05/06/2013 07:37 AM US Central Time, Brice Goglin wrote: > Le 06/05/2013 13:24, Pavan Balaji a écrit : >> On 05/06/2013 01:25 AM US Central Time, Brice Goglin wrote: >>> I think we removed C99 use (and configure check) from the code in 1.2 >>> because some compilers didn't properly support it. >> I looked at the code once more. It seems to assume fixed width integers >> all over the place. These are all stdint.h types which is c99. It >> looks like c89 support is not consistent in the code. >> >> Can you check inside HWLOC_SETUP_CORE whether you have the necessary >> level of c99 support and fail if you don't? > > I am far from understanding everything in the C99-or-not aspects of the > code and build-system so I am not the one going to change any of this > unless strictly required.
Fair enough. I can contribute patches as I find issues. So far things seem to be working well for us. -- Pavan -- Pavan Balaji http://www.mcs.anl.gov/~balaji
