There's some funny m4 logic in the CHECK_HEADERS for X11. Let me make sure I understand the intent:
- X11/Xlib.h: this file is required for X11 support - X11/Xutil.h X11/keysym.h: these files are optional for X11 support (i.e., we can still build X11 support without them, but if we have them, there's extra X11 goodies that can be used) Is that correct? Or do we *require* all 3 header files for X11 support? On Nov 1, 2013, at 11:20 AM, "Jeff Squyres (jsquyres)" <jsquy...@cisco.com> wrote: > Ya -- working on a new patch, too. > > > On Nov 1, 2013, at 11:10 AM, Brice Goglin <brice.gog...@inria.fr> wrote: > >> Can you first find out which header and library contains XOpenDisplay() >> on your Mac? >> >> Brice >> >> >> >> Le 01/11/2013 16:01, Jeff Squyres (jsquyres) a écrit : >>> Ah; I missed that because we have the X11 checking stuff done in hwloc.m4 >>> already -- I thought the ones in the Cairo were actually redundant. >>> >>> It looks like this logic isn't quite correct, anyway -- the X11 checks are >>> embedded in the Cairo and GL sections. Should they moved out to be >>> independent of Cairo and GL (and therefore only once, and include the >>> AC_DEFINE for HWLOC_HAVE_X11)? >>> >>> >>> >>> >>> >>> On Nov 1, 2013, at 10:53 AM, Samuel Thibault <samuel.thiba...@inria.fr> >>> wrote: >>> >>>> Jeff Squyres (jsquyres), le Fri 01 Nov 2013 15:12:31 +0100, a écrit : >>>>> Cool. Does the following patch look ok? If so, I'll commit to master >>>>> and v1.7: >>>> Err, no, we really need to have HWLOC_HAVE_X11 defined when X11 is >>>> available, otherwise we won't get the graphical lstopo. >>>> >>>> Samuel >>>> _______________________________________________ >>>> hwloc-devel mailing list >>>> hwloc-de...@open-mpi.org >>>> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel >>> >> >> _______________________________________________ >> hwloc-devel mailing list >> hwloc-de...@open-mpi.org >> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel > > > -- > Jeff Squyres > jsquy...@cisco.com > For corporate legal information go to: > http://www.cisco.com/web/about/doing_business/legal/cri/ > > _______________________________________________ > hwloc-devel mailing list > hwloc-de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
