Hi Brice, > On Jul 7, 2015, at 9:01 PM, D'Alessandro, Luke K <ldale...@indiana.edu> wrote: > > Hello > > I don't see any significant change in v1.11 regarding embedding, > especially with respect to CONFIGURE_DEPENDENCIES.
Okay. It didn’t seem likely. I must be doing something wrong. The actual project is in https://gitlab.crest.iu.edu/extreme/hpx/commits/develop, HWLOC_SETUP_CORES is called conditionally here https://gitlab.crest.iu.edu/extreme/hpx/blob/develop/config/hpx_config_hwloc.m4#L124, and HWLOC_DO_AM_CONDITIONALS is called unconditionally here https://gitlab.crest.iu.edu/extreme/hpx/blob/develop/config/hpx_do_am_conditionals.m4#L7. They're both called from the top-level configure.ac though AC_DEFUN macros. I’m building out-of-tree… perhaps that makes a difference? > Does v1.10 work when running autogen with the same versions of > automake/libtool/autoconf? It did, yes, though some other changes in our m4 structure happened in between the two points. Our new structure is basically toplevel configure macro 1 if () HWLOC_SETUP_CORE macro 2 HWLOC_DO_AM_CONDITIONALS The previous structure didn’t use macro 1 and macro 2. > I am using 1.14.1/2.4.2/2.69 here. I’m using 1.15, 2.4.6, and 2.69. > If you enter hwloc-1.11.0/tests/embedded, does "./run-embedded-tests.sh > ../../hwloc-1.11.0.tar.gz" fail? That works fine. > After running autogen.sh, I get hwloc-1.11.0/Makefile.in without the > line CONFIGURE_DEPENDENCIES = @CONFIGURE_DEPENDENCIES@ here. I bootstrapped our contrib with that same autogen.sh with no luck. > > Can you look at > https://github.com/open-mpi/hwloc/blob/v1.11/tests/embedded/configure.ac > and see if you're missing something from there? Maybe we forgot to > specify that some other configure lines are required. I don’t know. We don’t use HWLOC_SET_SYMBOL_PREFIX because we’re only embedding when there is no libhwloc.so in the path. And our HWLOC_SETUP_CORE is conditional. Thanks for looking at this. I’m trying to get some other people here to confirm the problem I’m having. Luke > > Brice > >> On Jul 7, 2015, at 2:28 PM, D'Alessandro, Luke K <ldale...@indiana.edu> >> wrote: >> >> Hi everyone, >> >> I’ve recently tried to update our embedded hwloc from 1.10.0 to 1.11.0 and >> I’m running into an issue. I essentially have: >> >> AS_IF([…], >> [HWLOC_SETUP_CORE([contrib/hwloc-1.11.0], […], [AC_MSG_WARN(…)], [1])]) >> >> HWLOC_DO_AM_CONDITIONALS >> >> I have `ACLOCAL_AMFLAGS = -I config -I contrib/hwloc-1.11.0/config` in the >> top level Makefile.am. >> >> It appears that, for whatever reason, (at least) @CONFIGURE_DEPENDENCIES@ >> isn’t being replaced in Makefile.in. >> >> $ make >> Making all in contrib >> make[1]: Entering directory `/home/ldalessa/obj/test/contrib' >> Makefile:755: warning: overriding commands for target `check-recursive' >> Makefile:487: warning: ignoring old commands for target `check-recursive' >> Making all in hwloc-1.11.0 >> make[2]: Entering directory `/home/ldalessa/obj/test/contrib/hwloc-1.11.0' >> make[2]: *** No rule to make target `@CONFIGURE_DEPENDENCIES@', needed by >> `/u/ldalessa/src/contrib/hwloc-1.11.0/Makefile.in'. Stop. >> make[2]: Leaving directory `/home/ldalessa/obj/test/contrib/hwloc-1.11.0' >> make[1]: *** [all-recursive] Error 1 >> make[1]: Leaving directory `/home/ldalessa/obj/test/contrib' >> make: *** [all-recursive] Error 1 >> $ >> >> I am by no means an AC/AM expert. >> >> Am I likely doing something obviously wrong? >> >> Has the embedding protocol changed since the 1.10 series? >> >> Thanks, >> Luke >
