hi, > Cool - the commit message says you moved 345 into branch - you mean 354, > right > ? The 'code reuse' one ? yes, it's a typo, I mean 354, sorry.
> Another thing is rev. 370; that changes the iteration through notes in a > pattern (sometimes the old iteration skipped some notes), perhaps you should > consider adopting that as well (370 applies it to the refactored code) yes. wolke Am Sun, 24 Aug 2008 17:23:21 +0200 schrieb Jakob Lund <[EMAIL PROTECTED]>: > Hi > > On Sunday 24 August 2008 17:08:47 [EMAIL PROTECTED] wrote: > > hi, > > we have add an branch rt_delete_instruments. > > also i have commit the changes back to the old delete instrument function. > > Cool - the commit message says you moved 345 into branch - you mean 354, > right > ? The 'code reuse' one ? > > > I am not sure, in moment I also remove the inline functions from > > instrument.h but it seems that hydroget get more performance with the > > inline functions. if this is true we better make them back to inline > > funktions. > > I think that the g++ -O3 (used when debug=0) might do this inlining anyway; I > didn't notice a _definitely_ improved performance from adding that. > > Another thing is rev. 370; that changes the iteration through notes in a > pattern (sometimes the old iteration skipped some notes), perhaps you should > consider adopting that as well (370 applies it to the refactored code) > > > > > greetings wolke > > > > > > > > Am Sun, 24 Aug 2008 15:56:29 +0200 > > > > schrieb Jakob Lund <[EMAIL PROTECTED]>: > > > On Sunday 24 August 2008 15:33:07 [EMAIL PROTECTED] wrote: > > > > hi jakob and krzysztoff, > > > > > > > > i have remove the changes from rev 354 and rev 371 (only local). > > > > than i have recompile hydrogen. Now I get no more errors or crashes if > > > > a drumkit or smaller drumkit would loaded. also the humantime function > > > > works correct. > > > > > > > > imo, this feature your planned is really great and we can create a > > > > branch!! for this. we planned rc1 to the end of august. > > > > imo, the changes from rev 354 and rev 371 needs a lot of testing and > > > > debugging. what do you think? > > > > > > > > greetings wolke > > > > > > Ok, maybe you're right about this. If you do it, be sure to merge out 373 > > > (which is just a fix-up for 371 regarding 'hear new notes') as well. > > > > > > Also, it leaves you with a possible crash when removing instruments / > > > changing drumkits while there are notes being played - possibly MIDI > > > notes coming into Hydrogen from a sequencer app or from a keyboard. > > > Perhaps a 'known bugs' note should accompany the release of RC1 then. > > > > > > - Jakob. > > > > > > > > > ------------------------------------------------------------------------- > > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > > challenge Build the coolest Linux based applications with Moblin SDK & > > > win great prizes Grand prize is a trip for two to an Open Source event > > > anywhere in the world > > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > > _______________________________________________ > > > Hydrogen-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge Build the coolest Linux based applications with Moblin SDK & win > > great prizes Grand prize is a trip for two to an Open Source event anywhere > > in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Hydrogen-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Hydrogen-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
