[email protected] wrote: > hiho, > >>> The problem was that the local_file_mgr saved only the filenames of >>> the samples (in drumkit.xml), without directory informations. I've >>> changed that so that it saves the relative filename, outgoing from the >>> root of the drumkit dir. >>> > sounds good. if its backwards compatible, imo, your patch can commit into > svn. > Yes it is, i applied it right now. >>> Btw. i suppose we should move the "save changes to instruments" >>> function from the drumkit prop's dialog to the right-click context >>> menu in the soundlibrary browser. >>> So you could right-click on a soundlibrary item and choose "save", >>> then h2 saves all changes to this kit (if it is loaded at the moment). >>> > > its a good idea to add this to the right-click context menue of soundlibrary > items. > > > do you want to remove the whole properties dialog or only the checkbox for > saving changes on instruments? the properties dialog is the only way to do > changes on library name, license or description if you doun't want to edit > the drumkit.xml file in external editor. > > imo, the best way off all is to add two new items to the right-click context > menue of the > soundlibrary instrument items in pattern editor. > > ------------------------- <--( old existing line ) > delete instrument <--( old existing item ) > ------------------------- <-- ( new line ) > save soundlibrary <--( new item ) > soundlibrary properties <--( new item ) > > and to remove any confusion with --save soundlibrary-- we change "save > soundlibrary" in > instrument menue on h2 top into "save as new soundlibray" or something > similar. and change the > functionality from "save sondlibrary" to the same in soundlibrary instrument > items from > pattern editor. (overwrite the current loaded library) > > :-)i hope somebody understand this oxford style english. sorry. > > I agree - but you should add the context menu entry to the entry of a *drumkit*, not to the instrument menu. Because you save the whole kit, not only one instrument.
And there seems to be a bug with the context menu.. if i right click on a soundlibrary i get 2 context menu's (sequentially). - Sebastian > greetings wolke > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by: > SourcForge Community > SourceForge wants to tell your story. > http://p.sf.net/sfu/sf-spreadtheword > _______________________________________________ > Hydrogen-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
