Am Sat, 29 Aug 2009 09:35:52 -0500 (CDT) schrieb "Gabriel M. Beddingfield" <gabr...@teuton.org>:
> > > On Thu, 27 Aug 2009, m.wolkst...@gmx.de wrote: > >> Can you point me to which commits have the changes on your branch? Or, > >> maybe make a patch and email it? > > ok...ok, here is a patch against trunk rev. 1331 > > > > here i also have replace all left std::string to QString, as sebastian has > > suggested. > > the diff contains also the playlist_background_Control.png. > > greetings wolke. > > Thanks! I won't be able to check this out until Sunday afternoon. Since > it's all GUI code, I'll stand down a little as long as you and mauser are > ready to support bugs. i don't understand your position into his statement :-? > > It's quite a few lines, though... a lot of new code. Are you guys sure > you want to do this? There will be issues (like the spelling error > "Pleas" instead of "Please" in PlaylistDialog.cpp :-)). ohh-... think, there are some more spelling errors. but hey, the dialog is much better with this redesign. and spelling errors are quickly fixed. > Peace, > Gabriel whatever. one of the main problems with the old design (text buttons) is the spacing. because in other languages you need mostly more letters to describe the button funktion than in english. also i think, the current(old) playlist dialog is really untested. why? it's exist since one year. and if many people did working with it, we will get more feedback here. but... since one year, nobody mentions just one word about the playlist. until two days ago. there is one people who modified russian translation and found this problem. see this thread. http://www.hydrogen-music.org/forum/?action=show_thread&fid=2&thread=1112&page=1 imo, the redesign as a bugfix with a small enhancement in work-flow. the old design looks more like a beta version and miss two essential function. 1. save playlist* 2. add current song to playlist. the new design fix all this errors. greetings wolke *into the old design you find a button "save playlist". but this function works like "save playlist as". now this function is called as it works, "save playlist as" and a new function "save playlist" works as expected, and save changes in loaded playlists, without opening every time an qfiledialog. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
