Hi Gabriel,
On Sunday 29 November 2009 11:11, Gabriel M. Beddingfield wrote :
=>
=> Hi guys,
=>
=> On Sun, 29 Nov 2009, Jérémy Zurcher wrote:
=>
=> >mkdir build && cd build && cmake -D WANT_JACK=1 .. && make
=> >build everything out of the source tree.
=>
=> Small warning about out-of-tree builds and hydrogen: When you
=> start H2, it won't find the 'global' data directory in the source
=> tree (the one that has all the default settings and stuff).[1] So,
=> either build H2 in-tree or install it after building
=> (-DCMAKE_INSTALL_PREFIX=$HOME/mychroot).
=>
=> Also, for Composite I've gone to a cmake build... and have done
=> several things to build on Jérémy's system.[2] Let me know if
=> you'd like me to port it to Hydrogen.
=>
=> > - all the GetDataDirectory and get_data_path should be held in a single
=> > class for multiple reasons ...
=>
=> I agree... but they sort of are are, already.
=> Preferences::getDataDirectory() is using get_data_path().
true, but this
bigdaddy jeyzu src $ grep -R data_path *
data_path.cpp:#include <hydrogen/data_path.h>
data_path.cpp:QString DataPath::__data_path;
data_path.cpp:QString DataPath::get_data_path()
data_path.cpp: if ( __data_path.isEmpty() ) {
data_path.cpp: __data_path = qStringPath;
data_path.cpp: QFile file( __data_path );
data_path.cpp: __data_path = DATA_PATH;
data_path.cpp: return __data_path;
hydrogen.cpp:#include <hydrogen/data_path.h>
hydrogen.cpp: .arg( DataPath::get_data_path() );
local_file_mgr.cpp:#include <hydrogen/data_path.h>
local_file_mgr.cpp: return getDrumkitsFromDirectory(DataPath::get_data_path() +
"/drumkits" );
local_file_mgr.cpp: QString path = QString(DataPath::get_data_path() )
+ "/drumkits/";
preferences.cpp:#include <hydrogen/data_path.h>
preferences.cpp: , demoPath( QString( DataPath::get_data_path() )+
"/demo_songs/" )
preferences.cpp: sPreferencesDirectory = DataPath::get_data_path();
sampler/sampler.cpp:#include <hydrogen/data_path.h>
sampler/sampler.cpp: QString sEmptySampleFilename =
DataPath::get_data_path() + "/emptySample.wav";
song.cpp:#include <hydrogen/data_path.h>
song.cpp: QString dataDir = DataPath::get_data_path();
show me that we've got some get_data_path() + "blah"; in different
places, no big deal, just needs a little bit of cleaning.
=>
=> -gabriel
=>
=> [1] Ref data_path.cpp:58 where it searches for the data
=> folder in the same directoray as the application.
I don't experience that issue on my linux box.
=>
=> [2] For example: Jérémy's script only works with
=> pkg-config... which is a no-go on OS's like Windows...
=> but the one for Composite can be configured to find the
=> packages in the absence of pkg-config. I did this by
=> adding custom modules like FindFLAC.cmake and
=> FindJACK.cmake.
=>
I first started with using thoses miscelaneous modules, and also the one
found in lmms, but as I don't have any windows or macos, I jumped on
pkg-config to ease my way as that was just a first shot. Bad point for
portability ...
=> !DSPAM:4b12abe338286551869753!
=>
------------------------------------------------------------------------------
=> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
=> trial. Simplify your report design, integration and deployment - and focus
on
=> what you do best, core application coding. Discover what's new with
=> Crystal Reports now. http://p.sf.net/sfu/bobj-july
=>
=> !DSPAM:4b12abe338286551869753!
=> _______________________________________________
=> Hydrogen-devel mailing list
=> [email protected]
=> https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
=>
=>
=> !DSPAM:4b12abe338286551869753!
--
Jérémy Zurcher
rte de Cully 29
1091 Grandvaux
+41 (0) 79 599 84 27
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Hydrogen-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
