Hi everyone, we had a serious bug in the last releases ( 0.9.4 and 0.9.5-beta1 ) which happened when creating a new instrument via "create new instrument". The new instrument was 'defect', it was not possible to save the notes which we're assigned to this new instrument.
The bug is a one liner: - Instrument *pNewInstr = new Instrument(QString( nID ), "New instrument", new ADSR()); + Instrument *pNewInstr = new Instrument( QString::number( nID ), "New instrument", new ADSR()); What went wrong? Everytime when a new instrument was created it got an invalid id. QString( nID ) returns the ascii char corresponding to the int nID and not a valid id (like "16"). This results in (partial) defect song files: 2079 <length>-1</length> 2080 <instrument>^P</instrument> 2081 <note_off>false</note_off> 2082 </note> One consequence of this bug is that you can't save any notes for instruments with those defect id's. The problematic thing about this is that it is very easy to loose your work. Hydrogen doesn't complain about the wrong id's when you save your song, so it is possible that you do a lot of work and encounter empty patterns at the next startup. This is why i would like to encourage everybody to update hydrogen. I'm going to fix this in the 0.9.4 branch as well after this mail.. - Sebastian ------------------------------------------------------------------------------ SOLARIS 10 is the OS for Data Centers - provides features such as DTrace, Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW http://p.sf.net/sfu/solaris-dev2dev _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
