Am Mon, 08 Mar 2010 23:11:59 +0100 schrieb Dave Stikkolorum <dav...@dds.nl>:
> On 09-03-10 00:01, m.wolkst...@gmx.de wrote: > > Am Mon, 08 Mar 2010 15:33:37 +0100 > > schrieb Dave Stikkolorum<dav...@dds.nl>: > > > > > >> Hi, > >> > >> I don't know who is doing all the good work of the undo-branche, > >> but I was wondering... > >> > >> I've made my patch for cut/copy/past working for the undo branche. > >> > >> I use a copy of the note_map of a pattern. > >> > >> Every edit action is really a change of the whole pattern. > >> > >> So I thought why not simply store copies of the note_map and restore > >> them when doing a undo. > >> > >> In this way not every action has to have it's own undo/redo function. > >> > >> So why is this not chosen? > >> Is it because of the memory use? > >> I must say I don't know how much a note_map uses. > >> > >> Greetings, > >> Dave > >> > > sebastian create the branch and implement the qudo framework. i do the most > > work to > > implement functions. > > > > you are right. to copy the whole notemap is a other possibility to do this. > > i also > > don't know how much memory will eat on each undo action if you copy the > > whole > > note-map. what ever, you talk about a working patch against the undo > > branch. can you > > attach the patch. so i can commit them. one thing left. i hope the copy > > note-map undo > > action have a destructor which delete the note-map correctly. else we have > > a lot of > > left note objects. > > > > greetings wolke > First I have to better it, so I hope to mail it > in a day. > > I will implement it with a (hopefully) good destructor. > Thanks for that. (now it's kind of a clipboard note_map that does not > clean nicely, I'll look into that ) > > One thing: de undostack calls the destructor of the undo objects only on > exit right? on exit and every time we call the QUndoStack.clear() function. this happens if you load a song or create a new one. then the than the stack have to clear. else we get problems with stack consistence. greetings wolke > > greetings, > Dave > > > > > > >> ------------------------------------------------------------------------------ > >> Download Intel® Parallel Studio Eval > >> Try the new software tools for yourself. Speed compiling, find bugs > >> proactively, and fine-tune applications for parallel performance. > >> See why Intel Parallel Studio got high marks during beta. > >> http://p.sf.net/sfu/intel-sw-dev > >> _______________________________________________ > >> Hydrogen-devel mailing list > >> Hydrogen-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > >> > >> > > ------------------------------------------------------------------------------ > > Download Intel® Parallel Studio Eval > > Try the new software tools for yourself. Speed compiling, find bugs > > proactively, and fine-tune applications for parallel performance. > > See why Intel Parallel Studio got high marks during beta. > > http://p.sf.net/sfu/intel-sw-dev > > _______________________________________________ > > Hydrogen-devel mailing list > > Hydrogen-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > > > > ------------------------------------------------------------------------------ > Download Intel® Parallel Studio Eval > Try the new software tools for yourself. Speed compiling, find bugs > proactively, and fine-tune applications for parallel performance. > See why Intel Parallel Studio got high marks during beta. > http://p.sf.net/sfu/intel-sw-dev > _______________________________________________ > Hydrogen-devel mailing list > Hydrogen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
