Am Fri, 22 Jul 2011 17:48:59 +0200 schrieb Hans Petter Selasky <hsela...@c2i.net>:
hi hans, thank you, i have committed all changes from your second patch. now it works as expected :). /g wolke > On Friday 22 July 2011 17:32:54 Hans Petter Selasky wrote: > > On Friday 22 July 2011 16:56:45 m.wolkst...@gmx.de wrote: > > > Am Wed, 20 Jul 2011 11:53:55 +0200 > > > > > > schrieb "m.wolkst...@gmx.de" <m.wolkst...@gmx.de>: > > > > Am Wed, 20 Jul 2011 11:00:48 +0200 > > > > > > > > schrieb Hans Petter Selasky <hsela...@c2i.net>: > > > > > On Tuesday 12 July 2011 19:13:26 Hans Petter Selasky wrote: > > > > > > Hi, > > > > > > > > > > > > I'm using Hydrogen under FreeBSD and there is no working MIDI > > > > > > support. > > > > > > > > > > > > I would like to request a JACK MIDI backend in Hydrogen. > > > > > > > > > > Hi, > > > > > > > > > > Answering my own question: > > > > > > > > > > Can someone commit the following patch? > > > > > > > > > > http://hselasky.homeunix.org:8192/hydrogen/hydrogen-0.9.6-jack-midi.p > > > > > at ch > > > > > > > > suuuuuper, i love you :). thx a lot for this patch. > > > > > > > > h2 midi out is a bit buggy. it handle note off messages mostly wrong. > > > > also sometimes notes will dropped. the midi out implementation need > > > > some love:). > > > > > > > > > The patch also includes some fixes to the CMAKE build file for > > > > > FreeBSD. > > > > > > > > > > I was not able to test MIDI out, hence it seems hydrogen is not > > > > > generating any MIDI events? > > > > > > > > hmm, maybe something goes wrong on midi out in 0.9.6. currently i can > > > > not test it here. greetings wolke > > > > > > hi, rev 2316 fix the problem with midi out events. but now it looks like > > > that the output create only unknown midi messages:(. i think that the > > > code in jack_midi_driver.cpp needs some explanations for me. > > > what do JackMidiDriver::JackMidiOutEvent(uint8_t buf[4], uint8_t len)? > > > and why JackMidiDriver::JackMidiWrite(jack_nframes_t nframes) is the > > > methode which read midi data when the name suggest that it will > > > write(output) data? > > > and did jack_midi_event_reserve which is called in > > > JackMidiDriver::JackMidiRead(jack_nframes_t nframes) > > > something like write mididata. or need this a jack_midi_event_write call? > > > > > > i don't know and also didn't understand it currently:) because i don't > > > read the jack api as well. whatever, i can need some help to fix the > > > unknown output message problem. > > > > Looks like I've overloaded some variables: > > > > +void > > +JackMidiDriver::JackMidiWrite(jack_nframes_t nframes) > > > > Rename local variable buffer into temp_buffer; > > > > +void > > +JackMidiDriver::JackMidiRead(jack_nframes_t nframes) > > +{ > > + uint8_t *buffer; > > > > + memcpy(temp_buffer, buffer + (4 * rx_in_pos) + 1, len); > > > > > > Rename local variable into jack_buffer; > > > > +void JackMidiDriver::handleQueueNote(Note* pNote) > > +{ > > + uint8_t buffer[4]; > > > > Rename local variable buffer into temp_buffer; > > > Updated patch here: > > http://hselasky.homeunix.org:8192/hydrogen/ > > --HPS > > ------------------------------------------------------------------------------ > 10 Tips for Better Web Security > Learn 10 ways to better secure your business today. Topics covered include: > Web security, SSL, hacker attacks & Denial of Service (DoS), private keys, > security Microsoft Exchange, secure Instant Messaging, and much more. > http://www.accelacomm.com/jaw/sfnl/114/51426210/ > _______________________________________________ > Hydrogen-devel mailing list > Hydrogen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel ------------------------------------------------------------------------------ 10 Tips for Better Web Security Learn 10 ways to better secure your business today. Topics covered include: Web security, SSL, hacker attacks & Denial of Service (DoS), private keys, security Microsoft Exchange, secure Instant Messaging, and much more. http://www.accelacomm.com/jaw/sfnl/114/51426210/ _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
