Hey, thanks for this Sebastian. I will try to use the pull request in the
future.
I don't think the other patch is quite ready for inclusion though. I would
need some advise on variable naming in Hydrogen. Also, the way it requires
an extra function for positioning the cursor when the song is stopped seems
a rather ugly solution but because the gui is unaware of bpm timeline
issues I couldn't work out a bettr way. I guess the ideal would be for the
gui to use this info too.. but that was beyond my understanding.
J
On Jun 21, 2013 9:39 PM, <[email protected]> wrote:
> Hi James!
>
> Thanks for your patches, it's great to see that some of these nasty
> audio-engine bugs are now getting fixed. Great work! Especially for a
> non-programmer. Your analysis is correct, the root of the problem of bug
> 1 is the mixed use of floating point and integer numbers in the
> calculation of ticks and the evaluation of the note queue. I will commit
> your patch in the next days as a first workaround, but i guess we have
> to look a little bit deeper for a better solution. At the moment i'm not
> sure how the ticks should be handled and if there is a cause to handle
> them once as floats and once as integers. I had no look at the second
> patch yet, but will do so..
>
> Btw, if you can use git pull request on github to send in the patches
> directly. Then they will also show up in our issue tracker. Here's a
> short howto: https://help.github.com/articles/using-pull-requests
> But it's no problem to send the patches to the list or the forum, if you
> don't like the git workflow for some reasons.
>
> Best regards,
> Sebastian
>
>
> On 2013-06-21 1:12, James Stone wrote:
> > HI there,
> >
> > (first of all, I am no programmer so please take everything I say with
> > a huge pinch of salt!!)
> >
> > I have been struggling to get hydrogen to do the right thing in terms
> > of BPM changes - it plays double beats when changing tempo from fast
> > to slow, and also, clicking on the timeline is messed up when hydrogen
> > is stopped - the cursor appears in the right place, but then jumps to
> > another part of the song when you press play.
> >
> > The first issue seems to be to do with the changing of the ticksize
> > (which is calculated as a float), and audioEngine_updateNoteQueue
> > playing a tick twice (as ticks are treated as integers in this
> > function)..
> >
> > The second issue I think, is due to the variable m_nSongPos being set
> > by the GUI when it is unaware of BPM changes in the song, then this
> > variable being used by the playback engine to define position in the
> > song.
> >
> > I have written a couple of patches, which I posted to the forum here:
> >
> > http://www.hydrogen-music.org/hcms/node/4502 [1]
> >
> > and here:
> >
> > http://www.hydrogen-music.org/hcms/node/4523 [2]
> >
> > .. both are probably considered dirty hacks - and are probably not the
> > "right way" to do these things - but on the other hand, they do
> > improve functionality significantly.
> >
> > I would appreciate thoughts from devs who know the codebase (and
> > programming) much better than me :)
> >
> > James
> >
> >
> > Links:
> > ------
> > [1] http://www.hydrogen-music.org/hcms/node/4502
> > [2] http://www.hydrogen-music.org/hcms/node/4523
> >
> >
> ------------------------------------------------------------------------------
> > This SF.net email is sponsored by Windows:
> >
> > Build for Windows Store.
> >
> > http://p.sf.net/sfu/windows-dev2dev
> >
> > _______________________________________________
> > Hydrogen-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Windows:
>
> Build for Windows Store.
>
> http://p.sf.net/sfu/windows-dev2dev
> _______________________________________________
> Hydrogen-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
>
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Hydrogen-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
