Hi Sebastian, So, maybe this is right time for learn git ;-) I already forked repository and applied all my patches. So please don't apply them. Now I'll test this stuff in real life and come back with pull request.
You can observe my work here: https://github.com/xjjx/hydrogen/commits/master I have not much time for organize my work, so I make all changes at once. I hope you cope this somehow ;-) BTW. which bugs are most important for release version 0.9.6 ? Pawel Dnia Poniedziałek, 19 Sierpnia 2013 19:53 <[email protected]> napisał(a) > On 2013-08-19 14:43, Pawel wrote: > Hi Pawel, > > the nice thing about git is that it is decentralized, so you don't need > a branch at our server. You can just fork the repository and create your > own branch. Then you can work with your own repository and send us a > pull request when you're ready with your changes. This is the "big > picture" of the git workflow, it would be too much to explain everything > in detail here :) But there are a lot of very good online ressources at > there. I would recommend to create an account at github first and fork > our repository there. Here is the link to the github help page: > https://help.github.com/categories/63/articles > > Just one more thing: Please keep the patches smaller :) Do not mix > feature additions with other changes (like refactoring or code cleanup > of existing code). This makes it hard to review the changes. It is > better to send in a couple of smaller patches then one large one. > > And beside this: You're patches are really welcome :) I will try to look > at them again this week, i did not work on hydrogen in the last weeks at > all. > > Thanks a lot, > Sebastian > > > Hi, > > > > I see more issues with JackSession (save midi connection for example). > > I found also problem with JackMaster mode - it was reported as bug > > #116. > > > > Can you apply this previous patch before I start writing a new one ? > > > > Or maybe you can give some access (new branch) to repo ? I not very > > familiar with git , I work a lot with SVN, so maybe you can give me > > some small instruction how to setup this. > > > > P. > > > > Dnia Sobota, 3 Sierpnia 2013 06:44 Pawel <[email protected]> napisał(a) > >> Hi, > >> > >> I made one more patch. This time it improve Playlist area. > >> > >> - JackSession - save playlist (if is not empty) and also copy all > >> songs > >> - JackSession - proper error handling > >> - JackSession - use SESSION_DIR variable while loading song > >> - Syntax fixes and some refactoring > >> > >> Hope this is useful ;-) In case of problems give me a note - I try to > >> fix. > >> > >> Best Regards > >> Xj > > > > > > > > > > ------------------------------------------------------------------------------ > > Get 100% visibility into Java/.NET code with AppDynamics Lite! > > It's a free troubleshooting tool designed for production. > > Get down to code-level detail for bottlenecks, with <2% overhead. > > Download for free and get started troubleshooting in minutes. > > http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk > > _______________________________________________ > > Hydrogen-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > > ------------------------------------------------------------------------------ > Introducing Performance Central, a new site from SourceForge and > AppDynamics. Performance Central is your source for news, insights, > analysis and resources for efficient Application Performance Management. > Visit us today! > http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk > _______________________________________________ > Hydrogen-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Hydrogen-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
