Hi Harry! Thanks for the initial code. I did some work today and reworked your cmake code. What i did: - Fixed some patching errors - NSMSESSION is now wanted only on linux - look for correct header file - stop configuration if NSMSESSION is wanted but header not found - make sure that H2CORE_HAVE_NSMSESSION is set properly - add IFDEFs around all NSM code - fixed indentation (spaces -> tabs, this is a hydrogen convention)
The commits can be found here: https://github.com/mauser/hydrogen . I can initiate a pull request when i had a look into the openSong() probem.. I hope that i can do this at this weekend. Best regards, Sebastian On 2014-08-08 0:29, Harry van Haaren wrote: > On Mon, Aug 4, 2014 at 11:58 AM, <mau...@smoors.de> wrote: > >> Do you have your code placed at a public repository somehwere so one >> could have a look at it? I'm not sure if i can help with those >> questions, but i will try. > > Hey, > > Cool, glad to hear 0.9.6 is release, and looking forward to finishing > the implementation of NSM! > Apologies for the response-delay, I've dedicated a little time each > day to finish NSM + H2 in the coming days, lets make this happen! > > Current status: > -NSM integration (using nsm.h for OSC layer) finished > > -CMake setup to add -lo (needs some xplatform changes) > > -non-session-manager will start / stop Hydrogen > > -non-session-manager will inform Hydrogen of Song to load using > gui/src/MainForm::openSongFile( const QString& sFilename ); > > Todo: > > -Hydrogen spits "Invalid Song file" error on recieving song to load: > (probably due to recieving openSongFile() when engine is in a state > which it can't actually load a song in? I'm not familiar with the Song > loading code) > > -Fix Hydrogen client name to be as NSM instructs: JackSession seems to > pass around a string for this, perhaps we can use a similar method? > > -Testing to make sure all is well > > Code available here (rebased on master just now), > https://github.com/harryhaaren/hydrogen/tree/nsm [1] > > Cheers, -Harry > > > Links: > ------ > [1] https://github.com/harryhaaren/hydrogen/tree/nsm > > ------------------------------------------------------------------------------ > Infragistics Professional > Build stunning WinForms apps today! > Reboot your WinForms applications with our WinForms controls. > Build a bridge from your legacy apps to the future. > http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk > > _______________________________________________ > Hydrogen-devel mailing list > Hydrogen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel