Hi, very nice ! IMHO a nice pull request should be accepted, the feature seems good enough and people (me) could be interested in pushing it forword towards completeness.
quick and well done On Friday 18 December 2015 00:39, Sacha Delanoue wrote : > On 18/12/2015 00:05, Steve Boyer wrote: > >Hey Sacha, > > > >There's a ticket open on github which relates to general midi. Not sure > >if you've seen it, but it might be a good place to start. > > > >https://github.com/hydrogen-music/hydrogen/issues/307 > > Hi Steve, > > I already had a quick glance to this ticket but I though it was totally > unrelated. Now I see it is not and that something may be broken. I’ll look > to it more closely. > > About the LilyPond export, it seems that I just needed the two hours after > sending my last mail to have a working version. Since I’m sending a mail > anyway I’ll use the occasion for a quick update. I joined the output PDF, > obtained by running LilyPond directly to the output file of Hydrogen, with > no manual input or setting of any kind. It works quite well. I still have > some adjustments and improvements to make of course but the hardest part is > done. If you want to see for yourself it is here > https://github.com/Shaac/hydrogen/tree/lilypond *but be careful* as I will > rebase, clean and refactor my code this weekend. It is not yet made to be > reviewed or worked upon, but anyway you can keep progress and test for > yourself if you are interested. > I’m very happy to have been able to make it work so quickly. > > Since with this I have all the features I need for the moment (the biggest > problems that does not bother me are only GM-kit support and no triplet > support), I will be less motivated to continue working for this missing > features and may not find the time to implement them for a while. So my > question is: do you want me to make a pull request with a partial feature, > for instance working only with GM-kit, or do you want to wait until the > feature is complete before any merge? Either way, before my pull request my > code will be clean and commented so that anyone may contribute easily if > they want. > > -- > Sacha “Shaac” Delanoue > ------------------------------------------------------------------------------ > _______________________________________________ > Hydrogen-devel mailing list > Hydrogen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel ----------------------- Jérémy Zurcher rue des Charmilles 7 1400 Yverdon-les-bains +41 (0) 79 599 84 27 ------------------------------------------------------------------------------ _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
