Paul/Thijs, Thanks for the response. I'll make a pull request when I have committed my changes to my copy of the repo. And thanks for the advice of making a separate branch- I probably wouldn't have thought to do that.
-John On Tue, 2016-01-19 at 10:01 +0100, Thijs van severen wrote: > hi John, and welcome to the team ! > > Paul pretty much nailed it :-) > You can check out this page (WIP) for github-specific instructions, > but note that 'make a branch for each task' is not yet on that page > (required!) : https://github.com/hydrogen-music/hydrogen/wiki/How-to- > contribute-code-using-Github > > grtz > Thijs > > 2016-01-19 4:34 GMT+01:00 Paul Vint <pjv...@gmail.com>: > > Hi John, > > > > I can't speak for the real devs, but I've been working on a few > > things too, and I think I can handle these questions: > > > > 1. Preferred manner of submitting a fix I would say is by a pull > > request. Might be best when new to reply here or in the bug report > > and refer to a branch on your fork if you want some input before > > making the pull request if you think some questions need to be > > answered or tests done etc. (Tip: Don't make my mistake of working > > on your "master" branch in your fork - make a branch for each task! > > It's a real pain to separate things otherwise) > > 2. Apparently there was only one question. > > 3. Thanks! And don't be surprised if replies are a bit slow right > > now - it seems that Sebastian and others are pretty occupied > > outside of here right now, but things are still moving along. > > > > Cheers > > Paul > > > > On 18 January 2016 at 14:56, John Brewer VIII <li...@octavius.org> > > wrote: > > > Hello, > > > > > > I am a big fan of Hydrogen and a programmer, and I'd like to get > > > involved with the project. I have a local clone of the repo, and > > > I'm > > > working on a few of the paper-cuts bugs in the issue tracker to > > > get > > > familiar with the code and brush up on my C++ (I use Java in my > > > day > > > job). I believe I have a fix for #314 (song name is not being > > > displayed > > > in window top bar), and am close to one for #243 (making the data > > > directory configurable). > > > > > > What's the preferred method of submitting a fix? The wiki on > > > GitHub > > > suggest sending a patch to the mailing list, but the DEVELOPERS > > > file > > > says to make a pull request. > > > > > > Thanks for such a cool product! > > > > > > -John Brewer > > > > > > --------------------------------------------------------------- > > > --------------- > > > Site24x7 APM Insight: Get Deep Visibility into Application > > > Performance > > > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > > > Monitor end-to-end web transactions and take corrective actions > > > now > > > Troubleshoot faster and improve end-user experience. Signup Now! > > > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > > > _______________________________________________ > > > Hydrogen-devel mailing list > > > Hydrogen-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > > > > > > > ----------------------------------------------------------------- > > ------------- > > Site24x7 APM Insight: Get Deep Visibility into Application > > Performance > > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > > Monitor end-to-end web transactions and take corrective actions now > > Troubleshoot faster and improve end-user experience. Signup Now! > > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > > _______________________________________________ > > Hydrogen-devel mailing list > > Hydrogen-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel > > > > > -- > follow me on my Audio & Linux blog <http://audio-and-linux.blogspot.c > om/> ! > > ------------------------------------------------------------------- > ----------- > Site24x7 APM Insight: Get Deep Visibility into Application > Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > _______________________________________________ > Hydrogen-devel mailing list > Hydrogen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
