Hi Phil,thank you for attention, I will open the issue.
In previous versions such instruments were muted - not happening now - and
lines were not deleted, as you could re-store the drumkit (or samples) and
those instruments came active again.
That would be a serious problem if it happens while opening a song file simply
asking for some not installed drumkits... but I have not tried this.
Il sabato 17 agosto 2019, 21:49:43 CEST, Philipp Müller
<thetruep...@googlemail.com> ha scritto:
Hey,
Well, I think it's a decent fallback strategy and does its job in preventing a
corrupt drumkit from getting loaded.
When accessing a sample file to create a sound multiple other tasks have to be
done as well, like checking its sample rate, length etc. All this happens way
before and is independent of whether the instrument is actually muted or not
and all those operations would cause fatal failures if the file had not been
present.
But, yes, it might be a better and less invasive approach to not delete but to
comment the corresponding parts in the song or drumkit file. Could you open a
issue at Github https://github.com/hydrogen-music/hydrogen/issues so we can
keep track of it?
Cheers,
Phil
On 8/15/19 8:42 PM, Stefano Carbonelli via Hydrogen-devel wrote:
Version: 1.0.0-beta1 (aug 14 2019)
Kernel: Linux 4.4.0-97-generic (i686) Distribution: Ubuntu 16.04.3 LTS
When opening an old file, program didn't find some instrument samples - that
was expected as samples had been converted to flac - BUT instead of muting
that instruments, it DELETED all layer information .h2song file. Example:
In new saved file: ... <instrumentComponent>
<component_id>0</component_id> <gain>1</gain> </instrumentComponent>
...
old file was: ... <instrumentComponent>
<component_id>0</component_id> <gain>1</gain> <layer>
<filename>16282_ltibbits_splash_A_custom_10_high_vol.wav</filename>
<min>0.66</min> <max>1</max> <gain>1</gain> <pitch>0</pitch>
</layer> <layer>
<filename>16284_ltibbits_splash_A_custom_10_med_vol.wav</filename>
<min>0.33</min> <max>0.66</max> <gain>1.75</gain>
<pitch>0</pitch> </layer> <layer>
<filename>16283_ltibbits_splash_A_custom_10_low_vol.wav</filename>
<min>0</min> <max>0.33</max> <gain>4.25</gain> <pitch>0</pitch>
</layer> </instrumentComponent> ...
_______________________________________________
Hydrogen-devel mailing list
Hydrogen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
_______________________________________________
Hydrogen-devel mailing list
Hydrogen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
