I personally dislike the idea of introducing this imprecision in order to approximate the tuplet behavior. You might not notice it at higher speeds but it could be quite obvious for very slow patterns. It's probably best to have a look at the current implementation and to come up with a clever way to patterns at a different granularity.
That's a good argument. Unfortunately, this is not that simple because it requires you to understand how the core of Hydrogen does process audio. I prepared some documentation in https://github.com/hydrogen-music/hydrogen/pull/737, which might help getting you started. But it's still quite some work. Ok I'll see it if I have time Currently there are not that much people involved in developing new features or fixing bugs in Hydrogen. In addition, we already do have very long todo list with issues that pilled up as well as not that much time to dedicate to the project. So, the fastest way to get a new feature is to implement it yourself. You already did a good job in figuring out the right files to change in your pull request. Why not going further? :) I'll do my best to support you in your efforts. Yes! I am currently completing the job started on pull request #364, which was similar to mine. I think to open a new pull req because #364 is based on previous version. If anybody else is reading I made pull request #756 for 16ths-meter pattern size. I did not understand if I have to clone H2 Repository twice, one for each pull request. Il lunedì 19 agosto 2019, 23:11:29 CEST, Philipp Müller <thetruep...@googlemail.com> ha scritto: Hey Stefano, On 8/16/19 12:37 AM, Stefano Carbonelli via Hydrogen-devel wrote: The small length differences are not so noticeable for me... I would use this subdivision even if not exact. Quarter and 8th 5-tuplet resolution are not really needed as one can use 16th 5tuplet res. skipping some ticks... but they could be implemented according to the previous positions. [...] Would it be easy for you to implement this? I personally dislike the idea of introducing this imprecision in order to approximate the tuplet behavior. You might not notice it at higher speeds but it could be quite obvious for very slow patterns. It's probably best to have a look at the current implementation and to come up with a clever way to patterns at a different granularity. Unfortunately, this is not that simple because it requires you to understand how the core of Hydrogen does process audio. I prepared some documentation in Doc structure and developer manual in documentation by theGreatWhiteShark · Pull Request #737 · hydrogen-music/hydrogen, which might help getting you started. But it's still quite some work. | | | | | | | | | | | Doc structure and developer manual in documentation by theGreatWhiteShar... NOTE: This pull request depends on #735 . I know this is really bad style. But since I had to touch almost all s... | | | Would you add this option (maybe on/off button that enables 16th-note resolution for pattern size...)? Currently there are not that much people involved in developing new features or fixing bugs in Hydrogen. In addition, we already do have very long todo list with issues that pilled up as well as not that much time to dedicate to the project. So, the fastest way to get a new feature is to implement it yourself. You already did a good job in figuring out the right files to change in your pull request. Why not going further? :) I'll do my best to support you in your efforts. Cheers, Phil
_______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
