Hi all, I've added initial cursor key editing support:
https://github.com/hydrogen-music/hydrogen/pull/847 If anyone feels like trying it out I'd love feedback. In fitting with the aim of making operation self-evident to the user and fitting with what they naturally expect from cursor keys/Enter, I realised that there was no single obvious default thing to do for a single keypress of 'Enter' in the song editor when in Select mode, so for the moment it does nothing. Alternatives would be to toggle as if the keyboard were always in Draw mode, or to start/end a select/move/copy operation, ie. the same as starting or ending a mouse drag, but this makes for a more complex set of potential states between mouse and keyboard select/drags. Any thoughts or opinions? Thanks! On Tue, 14 Apr 2020 at 11:29, Colin McEwan <colin.mce...@gmail.com> wrote: > Interesting idea! I was aiming to make basic operation modeless and as > obvious as possible, since I already hear from a lot of people that the > existing UI is already hard to get to grips with. Adding a richer editing > mode on top of that that could use the whole keymap might be really useful > for entering things faster, and I think there's a fairly obvious case to > make for having a mode like that in the pattern editor which uses the > instrument keys to enter notes! > > So, vague plan: > - Basic modeless cursor movement and editing for pattern editor, note > properties and song editor > - some cleanup and refactoring of existing GUI code > - add keyboard edit mode (just another mode for pattern editor; TBD how > this intersects with existing song editor modes) > > I'll think about behaviour of keyboard edit mode and sketch up an RFC. > > On Mon, 13 Apr 2020 at 17:49, <mau...@smoors.de> wrote: > >> Hi Colin! >> >> That's a great idea, i like it! I'm thinking about an "Edit mode" like >> in vi, where you press "Insert" and an cursor appears which tells you >> where the next letter will be inserted. For the Song Editor (the thing >> with the blue squares), i could imagine exactly such a mode. The current >> square would be highlighted. An extra "mode" would also avoid conflicts >> with current keyboard input. The keyboard input mode would be >> de-activated if you hit ESC or click somewhere with your mouse (maybe?). >> Just an idea :) I suppose this may also work without that special mode, >> but then you may have more troubles with the key bindings. >> >> Best regards, >> Sebastian >> >> >> Am 13.04.2020 14:02, schrieb Colin McEwan: >> > Hi all, >> > >> > I'm implementing something I (and others I know) have wished for in >> > Hydrogen for a while -- editing patterns and notes using keyboard >> > input with the cursor/arrow keys to move and place/alter notes and >> > patterns. >> > >> > I'd appreciate a little feedback on whether this would be likely to be >> > a welcome feature or not, if anyone has strong opinions on how it >> > should work, etc. >> > >> > Principles I've been following have been to follow the obvious key >> > movement conventions, avoid clashing with any existing instrument >> > keys, and a fairly minimal approach to modifying existing code (I'm >> > tempted to do some cleanup but as a separate activity), and also >> > cleaning up input focus and tab key ordering. >> > >> > For background, the Hydrogen users I know (who have suggested this and >> > other niggles) tend to be drummers and drum crew leaders who use it >> > for composition and teaching, and not in actual production or >> > performance. >> > >> > Thanks all! >> > >> > -- >> > C. >> > _______________________________________________ >> > Hydrogen-devel mailing list >> > Hydrogen-devel@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/hydrogen-devel >> >> >> _______________________________________________ >> Hydrogen-devel mailing list >> Hydrogen-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/hydrogen-devel >> > > > -- > C. > -- C.
_______________________________________________ Hydrogen-devel mailing list Hydrogen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/hydrogen-devel