Hi,
good idea! I could prepare the release in the next days, i also want to
re-enable jackd support for the windows build. Are there any other
things which need to be fixed/cherry-picked for 1.0.2? Btw, the
corresponding branch would be "releases/1.0". Before 1.0, we always had
branches like "0.9.7" which clashed with the tag "0.9.7" :-/
Best regards,
Sebastian
Am 20.11.2020 19:21, schrieb Colin McEwan:
Hi all,
It looks like the race condition that shows up in Big Sur [
https://github.com/hydrogen-music/hydrogen/issues/982 ] is a critical
issue. Should we spin a 1.0.2 / 1.0.1-1 release with the fix in?
I haven't PR'd the fix as 1.0.1 is a tag and we can't merge to tags,
but the change is at:
https://github.com/cme/hydrogen/commit/81542d5ab1ab823e357f1805b84ae0bfaaa5446b
As well as fixing that race condition, I have a work-in-progress
branch on which I've added checks to PatternList that will assert that
the AudioEngine lock is held by any thread accessing the 'current' or
'next' PatternLists which may be modified by the audio thread. Using
this, it found the Big Sur issue, and didn't find any more, so that's
a nice little confidence boost.
I'm going to clean up this branch, review if there are any other
structures the same check should apply to, and submit that as a PR on
master, to find any other instances of this sort of thing, and prevent
any new ones. Enabled *only* on debug builds, though.
_______________________________________________
Hydrogen-devel mailing list
Hydrogen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
_______________________________________________
Hydrogen-devel mailing list
Hydrogen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/hydrogen-devel
