I just took a look at the patch. It seems to me that using va_start instead of va_copy would be more portable, faster as well (Hypertable::String::format use this and extensively tested with various buffer sizes.)
On Aug 29, 6:43 pm, "Joshua Taylor" <[EMAIL PROTECTED]> wrote: > I've been having problems with RangeServer crashing in log4cpp when it has > long log messages. The one that has been killing me is in > split_notify_master when the row keys involved are in the 400-900 byte > range. > > When log4cpp tries to format something over 1023 characters, it blows up. > It has some code in place to handle long log messages, but apparently it has > never been tested because it is broken. The code has been broken for the > last 5 years, up to and including the recent 1.0 release of log4cpp. I've > submitted a test case and fix to the SourceForge project. I've attached the > fix, in case other people are having the same problem. The patch is taken > against the 1.0 code base, but according to their CVS, these files haven't > changed in 5 years, so you can probably apply it to older versions too. > > Josh > > 0003-Fixed-bug-in-StringUtil-vform.patch > 1KViewDownload --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Hypertable Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/hypertable-dev?hl=en -~----------~----~----~----~------~----~------~--~---
