On Apr 25, 2009, at 10:48 PM, Michael Klishin wrote:

>
> Hi,
>
> I have a tiny patch that I had to apply to make Hypertable's master
> build on Ubuntu machines with gcc 4.3.3.
> So far I couldn't find any contribution guidelines,

Are these helpful?

http://code.google.com/p/hypertable/wiki/SourceCode
http://code.google.com/p/hypertable/wiki/CodingConvention


> and one regression
> test (#36 AFAIR) fails for me,

Is it Thriftclient-perl? The number is not reliable as the config  
system skips certain optional component when they are not installed.

>
> so I just published it on a branch at github:
>
> http://github.com/michaelklishin/hypertable/tree/add_include_to_build_with_gcc433_on_ubuntu
>

This is OK, but a cleaner fix would be use std:: consistently  
(including std::clock_t) and get rid of time.h, or just don't use  
clock* instead of std::clock*)


> I may just scratch issue's surface here, and not seeing real problem,
> but it is less than 24 hours since I pulled down the code base :)

Welcome :) Feel free to ask any questions here. Your feedback is  
appreciated.

__Luke


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Hypertable Development" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/hypertable-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to