Good catch! Thanks, Phoenix. - Doug
On Thu, Aug 6, 2009 at 4:33 AM, Phoenix <[email protected]> wrote: > > Hi Doug, > The current MACRO HT_DECODE_BYTES32 maintains a wrong "remaining > bytes" record. > #define HT_DECODE_BYTES32(_ip_, _r_, _out_, _len_) do { \ > uint32_t _tmp_; \ > HT_DECODE_I32(_ip_, _r_, _tmp_); \ > HT_DECODE_NEED(_r_, _tmp_); \ > _out_ = (uint8_t *)(_ip_); \ > _r_ -= _tmp_; \ > _ip_ += _tmp_; \ > _len_ = _tmp_; \ > } while (0) > > > The remaining bytes' size is stored in __r__. The var _tmp_ is the > length of the following data's length. > > Here the remaining bytes is subtracted twice: > 1. In HT_DECODE_NEED(_r_, _tmp_), _r_ -= _l_; > 2. In current MACRO _r_ -= _tmp_; > > > The line "_r_ -= _tmp;" should be removed. > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Hypertable Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hypertable-dev?hl=en -~----------~----~----~----~------~----~------~--~---
