Also Mateusz, if you could add a regression test and an example somewhere for this feature, that would be great. If not, I can work on that.
-Sanjit On Wed, Oct 14, 2009 at 1:41 PM, Sanjit Jhala <[email protected]> wrote: > Is it just the HqlInterpreter or HqlParser as well? I feel HqlInterpreter > should be in libHypertable rather than libHyperTools since I think tools > provides debugging or helper interfaces (command shells, load generator, > dumplog etc.) whereas HqlInterpreter seems more like a core piece of the > specific interface to the Hypertable client (there's already a > CommandInterpreter class in tools library). It seems like it should belong > in the same place as the Client. > > OTOH I'm not sure why we have the HqlInterpreter and HqlCommandInterpreter. > Seems like they could be rolled into one class. > > -Sanjit > > > > > > On Tue, Oct 13, 2009 at 5:23 PM, Luke <[email protected]> wrote: > >> >> We might need refactor the code a bit as this creates a circular >> dependency between libHypertable and libHyperDfsBroker. Have you tried >> to build shared lib version of hypertable out of this? It wouldn't >> link in that case. >> >> We can move HqlInterpreter* stuff into libHyperTools to remove the >> circular dependency. Doug and Sanjit, what do you think? >> >> __Luke >> >> On Sat, Oct 10, 2009 at 6:04 AM, Mateusz Berezecki <[email protected]> >> wrote: >> > >> http://github.com/mateuszb/hypertable/commit/f1295603a939ba034927c10d020d763780eb6c22 >> > >> > Mateusz >> > >> > > >> > >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Hypertable Development" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/hypertable-dev?hl=en -~----------~----~----~----~------~----~------~--~---
