Hi Daven,
The change looks good to me.
When the fix is pushed to open JDK repository, please notify me, so that
I can update the CR status.
thanks,
Yong
On 2012/8/9 11:21, Deven You wrote:
Hi Jeffrey,
Thanks for your review. I have updated the webrev[1] according to your
comments.
To Masayoshi,
After Jeffrey confirm this version of webrev please give your opinion
as Jeffrey mentioned we need a reviewer. And then I will ask Jonathan
to help me commit this patch.
Thanks a lot!
[1] http://cr.openjdk.java.net/~youdwei/ojdk-292/webrev.01/
<http://cr.openjdk.java.net/%7Eyoudwei/ojdk-292/webrev.01/>
On 08/08/2012 11:01 AM, Yong Jeffrey Huang wrote:
Hi Daven,
The symbol change is correct. The internal CR(change request) number
of this bug is 7189611, and I assigned myself as the responsible
engineer. When you fix and integrate the bug, could you please add
the CR number and its synopsis in your change set comments.
Please refer to
http://openjdk.java.net/guide/producingChangeset.html. In section
Formatting a Changeset Comment, there is the example.
"<bugid>: <synopsis-of-symptom>" should be "7189611: Venezuela
current Currency should be Bs.F."
When the bug fix is integrated, could you please notify me, so that I
can update the CR status.
-----------------------------------------------------------------------------------------------------------------------------
For regression testing, I think you do not need to add
test/java/util/Currency/VECurrencyTest.java.
You need to add below lines in the end of
jdk/test/sun/text/resources/LocaleData
#bug 7189611
CurrencyNames/es_VE/VEF=Bs.F.
and also add 7189611 at the end of @bug in comments in
jdk/test/sun/text/resources/LocaleDataTest.java
Change Set for your reference is
http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/780b11d28712
BTW, I am not qualified to be a formal reviewer in JDK project.
thanks,
Yong
On 2012/8/7 15:35, Deven You wrote:
Hi All,
I have searched from both wikipedia and windows config, the
Venezuela currency symbol is already updated from "BsF. to " "Bs.F.".
The ISO 4217 also map current Venezuela currency to "Bs.F.". I have
made a patch[1] to reflect this change. Could anyone take a look!
Thanks a lot!
[1] http://cr.openjdk.java.net/~youdwei/ojdk-292/webrev.00/
<http://cr.openjdk.java.net/%7Eyoudwei/ojdk-292/webrev.00/>
--
Best Regards,
Deven
