On 8/12/13 7:40 PM, Yong Huang wrote:
Hi Naoto,
It's to add the EUR symbol in CurrencyNames_lv_LV.properties, but the
old symbol LVL=Ls is not removed. LocaleDataTest is to check that EUR
symbol is in CurrencyNames_lv_LV.properties. It works with the
transition because the EUR symbol is in lv_LV before the transition and
will not be removed after the transition.
You meant "Ls" here, right?
LVL=Ls will remain in the file CurrencyNames_lv_LV.properties after the
transition but will not bring any regression.
OK, looks good to me.
Naoto
thanks,
Yong
On 2013/8/13 6:03, Naoto Sato wrote:
Hi Yong,
Does test/sun/text/resources/LocaleDataTest work before/after the
transition date? I know test/java/util/Currency tests work with the
transition, but don't think the LocaleDataTest test works.
Naoto
On 8/12/13 1:49 AM, Yong Huang wrote:
Hello All,
The updated webrev is at
http://cr.openjdk.java.net/~yhuang/8021121/webrev.01/
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021121
The transition logic of currency of lv_LV is placed in source file and
regression test.
thanks,
Yong
On 2013/8/7 0:45, Naoto Sato wrote:
Yong,
There already is a logic in Currency class to deal with such a future
transition nicely. That's what I meant.
Masayoshi,
Then it will be a regression till 1/1/2014. I don't see any problem
using the transition logic here, IMO.
Naoto
On 8/6/13 2:13 AM, Masayoshi Okutsu wrote:
Hi Yong,
I think it's OK to use EUR without specifying the transition date-time
for JDK 8.
Thanks,
Masayoshi
On 8/6/2013 11:44 AM, Yong Huang wrote:
Hi Naoto,
To place the transition logic, do you mean I need to add comments in
source file or do I just need to explain it in this email thread?
The currency change will take place in January 2014 and Java 8 is
still not released at that time. So when Java 8 is released, the
currency of LV will already be changed. If I fix the bug after Jan
2014, it will be near the release date of Java 8 and maybe only
stopper bug is allowed to fixed at that time.
thanks,
Yong
On 2013/8/6 2:32, Naoto Sato wrote:
At the moment, they still use LVL for their currency, so I think the
transition logic needs to be placed.
Naoto
On 8/4/13 7:46 PM, Yong Huang wrote:
Hello,
This is the review request for
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8021121
Webrev: http://cr.openjdk.java.net/~yhuang/8021121/webrev.00/
thanks,
Yong
