On 23/07/2014 09:46, Masayoshi Okutsu wrote:
Revised the webrev:
http://cr.openjdk.java.net/~okutsu/9/8048123/webrev.01

The changes from the previous one are:
- Changed <pre><code> (originally <pre><tt>) to <pre>{@code
- Replaced StringTokenizer with String.split()
- Eliminated RuntimeException
The use of {@code ..} and replacing the usage of StringTokenizer look good me.

I'm not so sure about silently ignoring errors in the property value, mostly because it would lead to incorrect behavior that is likely to be very difficult to track down. If there area used logging then there might be some hope of finding it but this isn't the case.

-Alan

Reply via email to