Thanks, forgot about GensrcLocaleData.gmk being used by more than one
module.
/Erik
On 2014-10-21 02:16, Naoto Sato wrote:
Thank you, Erik. Will incorporate your suggestions in the next webrev.
As to inlining GensrcLocaleData.gmk, it is used not only in
jdk.localedata, but also in java.base where English locale data is
included. So it cannot be inlined into Gensrc-jdk.localedata.gmk.
Naoto
On 10/20/14, 12:54 AM, Erik Joelsson wrote:
Hello Naoto,
With this split, I would rather see GensrcCLDR.gmk be renamed
Gensrc-jdk.localedata.cldr.gmk and have the "all" targets etc added to
it. Then Gensrc-jdk.localedata.gmk should no longer include it. Ideally
GensrcLocaleData.gmk would be inlined into Gensrc-jdk.localedata.gmk.
Note that the targets declared in these files that are named after the
modules (e.g. jdk.localedata) aren't really used. The files are just
called with default target. Also, when jigsaw M2 hits, I have done away
with the targets completely in these files, as they were just
boilerplate, and have a wrapper that adds them automatically instead.
/Erik
On 2014-10-18 00:31, Naoto Sato wrote:
Hello,
Please review the proposed changes to the following bug:
https://bugs.openjdk.java.net/browse/JDK-8061382
The webrev is available at:
http://cr.openjdk.java.net/~naoto/8061382/webrev.00/
This is mainly build changes to separate CLDR locale data into a new
module. All those CLDR source changes (for .xml files) are merely the
location changes in the repository, no changes are made to their file
contents.
Naoto
