Sean,
Based on https://bugs.openjdk.java.net/browse/JDK-4159519,
"historically" our ebcdic charsets
alway do
IBMxxxx.map:
0x15 U+000a
0x25 U+000a
IBMxxx.c2b
0x15 U+0085
IBMxxx.nr
0x25 U+000a
Someone had complained that "this is not correct". But it has been this
way for a long time.
The rest looks fine.
I might have overlooked the implementation for the early update releases?
-Sherman
On 2/24/15 6:02 AM, Seán Coffey wrote:
I've updated the JDK 9 changes to take account of the recent NIO
charset work that Sherman undertook for modules.
new webrev : http://cr.openjdk.java.net/~coffeys/webrev.8071447.v2/webrev/
I'm also pasting the map file differences here between the 1025 and
1166 IBM charsets for easier comparison [1].
regards,
Sean.
[1]
$diff IBM1025.map IBM1166.map
1d0
< #Generated from IBM1025.java
23c22
< 0x15 U+000a
---
> 0x15 U+0085
68,69c67,68
< 0x42 U+0452
< 0x43 U+0453
---
> 0x42 U+04d9
> 0x43 U+0493
74c73
< 0x48 U+0457
---
> 0x48 U+049b
83,86c82,85
< 0x51 U+0459
< 0x52 U+045a
< 0x53 U+045b
< 0x54 U+045c
---
> 0x51 U+04a3
> 0x52 U+04e9
> 0x53 U+04b1
> 0x54 U+04af
88c87
< 0x56 U+045f
---
> 0x56 U+04bb
91c90
< 0x59 U+0402
---
> 0x59 U+04d8
100c99
< 0x62 U+0403
---
> 0x62 U+0492
105c104
< 0x67 U+0407
---
> 0x67 U+049a
107c106
< 0x69 U+0409
---
> 0x69 U+04a2
114,116c113,115
< 0x70 U+040a
< 0x71 U+040b
< 0x72 U+040c
---
> 0x70 U+04e8
> 0x71 U+04b0
> 0x72 U+04ae
119c118
< 0x75 U+040f
---
> 0x75 U+04ba
227c226
< 0xe1 U+00a7
---
> 0xe1 U+20ac
$
On 06/02/2015 17:51, Seán Coffey wrote:
Looking for a code review around the addition of this new charset. I
haven't added a charset before so I'm hoping I caught all the
necessary steps and edits.
Sherman, would appreciate if you could cast a careful eye over this one.
In particular, I'm wondering if I need to take extra steps due to
this comment in the extsbcs file :
# map tables for 1140-1149 are updated manualy with the u+20ac entry
(Is 1166 impacted? what's the reason for such a comment?)
Also - I didn't create an .nr file for IBM1166 in
make/data/charsetmapping/ - Let me know if it's needed.
bug report : https://bugs.openjdk.java.net/browse/JDK-8071447
webrev : http://cr.openjdk.java.net/~coffeys/webrev.8071447/webrev/
regards,
Sean.
