Hi Naoto,

Thanks for the review.

Yes, you are correct, I somehow missed to mention the correct reason for that.

Nishit Jain
On 16-09-2016 22:30, Naoto Sato wrote:
Looks good.

BTW, I believe making it "final" means to make sure every threads are guaranteed to see the same value, not because it is not changed after the construction.


On 9/16/16 2:09 AM, Nishit Jain wrote:

Please review the fix for JDK-8165984

Bug: https://bugs.openjdk.java.net/browse/JDK-8165984
Webrev: http://cr.openjdk.java.net/~nishjain/8165984/webrev.01/

Fix: the private lookup variable is made final in PropertyResourceBundle
as after initialization it is not changed anywhere. lookup variable is
made volatile in ListResourceBundle to make sure that multiple threads
read the value from main memory.

Nishit Jain

Reply via email to