Thanks, Martin. Updated the webrev for each: http://cr.openjdk.java.net/~naoto/8176160/webrev.01/ http://cr.openjdk.java.net/~naoto/8176847/webrev.01/
Naoto On 5/31/17 1:00 PM, Martin Buchholz wrote:
Thanks - looks good. --- + private final static List<String> cals = + List.of("gregorian", "japanese", "julian");If you inline this into main, your beautiful stream pipeline will be even more beautiful!--- +import static java.util.Calendar.Builder;My colleagues would frown upon static importing a builder - just use "Calendar.Builder" !On Wed, May 31, 2017 at 12:41 PM, Naoto Sato <naoto.s...@oracle.com <mailto:naoto.s...@oracle.com>> wrote:Hi Martin, These are the issues you filed with proposed fixes. I supplemented the tests to them. Can you please review these changes: https://bugs.openjdk.java.net/browse/JDK-8176160 <https://bugs.openjdk.java.net/browse/JDK-8176160> http://cr.openjdk.java.net/~naoto/8176160/webrev.00/ <http://cr.openjdk.java.net/~naoto/8176160/webrev.00/> https://bugs.openjdk.java.net/browse/JDK-8176847 <https://bugs.openjdk.java.net/browse/JDK-8176847> http://cr.openjdk.java.net/~naoto/8176847/webrev.00/ <http://cr.openjdk.java.net/~naoto/8176847/webrev.00/> https://bugs.openjdk.java.net/browse/JDK-8176853 <https://bugs.openjdk.java.net/browse/JDK-8176853> http://cr.openjdk.java.net/~naoto/8176853/webrev.00/ <http://cr.openjdk.java.net/~naoto/8176853/webrev.00/> Naoto
