Hi Nishit,

The webrev and updates to the javadoc look fine.

However, the summary of the issue does not reflect the issue and implies the implementation is wrong;
but it is the javadoc that need clarification.

Please change the issue summary (on both the CSR and the issue) to reflect the true cause, something like:

[Fmt-*] Clarify DecimalFormat description of FieldPosition use

Thanks, Roger


On 11/17/2017 7:21 PM, Naoto Sato wrote:
+1

Naoto

On 11/16/17 10:52 PM, Nishit Jain wrote:
Hi,

Please review the fix for JDK-6354947

Bug: https://bugs.openjdk.java.net/browse/JDK-6354947
Webrev: http://cr.openjdk.java.net/~nishjain/6354947/webrev.02/
CSR: https://bugs.openjdk.java.net/browse/JDK-8191014

Fix: Clarified handling of the FieldPosition settings in the java.text.Format APIs specification.

Regards,
Nishit Jain

Reply via email to