+1
Naoto
On 2/23/18 12:33 AM, Nishit Jain wrote:
Thanks Naoto,
Please check the updated webrev
http://cr.openjdk.java.net/~nishjain/8060094/webrev.04/
Edits made: In FormatLocale.java, clarified the exception messages about
the locale used and removed an unused import.
Regards,
Nishit Jain
On 23-02-2018 00:56, Naoto Sato wrote:
Hi Nishit,
In the test case, the exception error messages may be more helpful if
there is a distinction between the two (line 103 and 120) mentioning
the formatter is using the default or specified locale.
Naoto
On 2/22/18 3:51 AM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8060094.
Bug: https://bugs.openjdk.java.net/browse/JDK-8060094
Webrev: http://cr.openjdk.java.net/~nishjain/8060094/webrev.03/
CSR: https://bugs.openjdk.java.net/browse/JDK-8197916
Cause: The Formatter APIs were not using the correct locale for upper
casing when specified during instance creation or during format()
call. The default locale was getting used irrespective of whether a
Locale is specified in the API.
Fix: Modified the APIs to use the locale specified.
Regards,
Nishit Jain
