Looks good. Since you modified the test case, please add the copyright
year 2018 in the test case before you push.
Naoto
On 11/4/18 10:26 PM, Deepak Kejriwal wrote:
Hi all,
Please review the fix for JDK8u Backport of
https://bugs.openjdk.java.net/browse/JDK-8171049
Webrev: http://cr.openjdk.java.net/~rpatil/8171049/webrev.00/
Master Bug changeset and Review details:
JDK Change set: http://hg.openjdk.java.net/jdk10/jdk10/jdk/rev/965d4dde0086
JDK Review Thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-August/049037.html
New test file "TestEraDisplayName.java" added as part of fix is modified as per
jdk 8 release:-
. All test written in jdk 10 are written to verify the CLDR resource. Since, in
case of jdk 8 "CLDR" is not default locale providers, added
Djava.locale.providers=CLDR as JVM parameter to test.
. Some resource keys in jdk 8 does not exist in both CLDR and JRE due
to which Era.getDisplayName() returns numeric value. Modified such test cases
accordingly.
Regards,
Deepak