Hi Chris,
Thank you for the comments. I updated the CSR and the webrev:
https://bugs.openjdk.java.net/browse/JDK-8217938
https://cr.openjdk.java.net/~naoto/8216546/webrev.01/
Naoto
On 1/31/19 1:15 AM, Chris Hegarty wrote:
Naoto,
On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote:
...
https://bugs.openjdk.java.net/browse/JDK-8217938
http://cr.openjdk.java.net/~naoto/8216546/webrev.00/
This looks good. Just a few very minor comments.
1) To be consistent can you please include the addition of the
word ‘conditions’ to the following methods:
“... the following *conditions* is true:"
isJavaIdentifierPart(char ch)
isJavaIdentifierPart(int codePoint)
isJavaLetter(char ch)
isJavaIdentifierPart(char)
2) There was a small correction in isJavaIdentifierPart(int).
Replace "the character" with "the code point"
Thanks,
-Chris.
